On Thu, 23 Oct 2025 19:23:51 GMT, Daniel Hu <[email protected]> wrote:
>> These changes prevent entire binary files from being loaded into memory for >> build/AbsPathsInImage.java test. Files are buffered and matching is >> performed using Knuth–Morris–Pratt algorithm. GHA passes and test passes on >> linux x64. Correctly fails when running with jdk build with >> `--enable-absolute-paths-in-output`. > > Daniel Hu has updated the pull request incrementally with one additional > commit since the last revision: > > Add comments Thanks, I think this looks good. I tried it myself on a build where I set `--enable-absolute-paths-in-output` and compared the matches found with what `strings` found on libjvm.dylib, and from what I can tell, the test didn't miss anything. ------------- Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26030#pullrequestreview-3372303638
