On Mon, 22 Sep 2025 14:05:28 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> We currently have three macros (as in "functions", not just simple strings) >> that are assigned in spec.gmk. This is in contrast with the rest of the >> values assigned in spec.gmk, and it is surprising and is forcing an odd >> syntax. Furthermore, these macros are named as constants, and not as we >> normally name functions/macros. >> >> We should move them to normal .gmk code, and rename them. >> >> The three macros are `SET_SHARED_LIBRARY_ORIGIN`, `SET_EXECUTABLE_ORIGIN` >> and `SET_SHARED_LIBRARY_NAME`. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into no-macros-in-spec > - Fix indentation > > Co-authored-by: Erik Joelsson <[email protected]> > - 8368102: Don't store macros in spec.gmk Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/27394#pullrequestreview-3252999579
