On Thu, 18 Sep 2025 16:17:24 GMT, Naoto Sato <[email protected]> wrote:

>> An alternative implementation to https://github.com/openjdk/jdk/pull/27338, 
>> which removes the entire gensrc stage and instead permanently checks in the 
>> generated Java files.
>
> src/java.base/share/classes/java/nio/charset/IllegalCharsetNameException.java 
> line 30:
> 
>> 28: /**
>> 29:  * Unchecked exception thrown when a string that is not a
>> 30:  * <a href="Charset.html#names">legal charset name</a> is used as such.
> 
> Could utilize new construct as `{@linkplain Charset##names legal charset 
> name}`

I assume Magnus is using the generated classes and I think best to not change 
anything else with this update. We can follow-up yesterday for "opportunities" 
to modernize.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27352#discussion_r2360178485

Reply via email to