On Thu, 7 Aug 2025 22:18:43 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few issues and more are coming. I want to push the agent so it is
>> possible to provide reproduces for problems uncovered by this agent.
>>
>> The agent has 2 modes now:
>> - regular that is compatible with most of tests including other jvmti, jdi
>> and jdb tests
>> - debugger, that additionally test some function requiring solo
>> capabilities and not compatible with debugger and some jvmti tests
>>
>> The tests incompatible wiht agent (IR, CDS) and some individual tests from
>> tier1 are excluded. There are not plans to support stable execution of all
>> tests with agent right now. However it provokes some crashes worth to be
>> used for exploratory testing.
>> Note, that flagless tests are excluded automatically and not executed in
>> this mode.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> makefiles fixed
make/RunTests.gmk line 73:
> 71: endif
> 72: endif
> 73:
What happened here?
make/RunTests.gmk line 874:
> 872: $1_JTREG_BASIC_OPTIONS += $$(addprefix
> $$(JTREG_PROBLEM_LIST_PREFIX), $$(wildcard \
> 873: $$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \
> 874: ))
You need to add the definitions of `LIBRARY_PREFIX` and `SHARED_LIBRARY_SUFFIX`
for this to work in a remote testing situation.
I asked you to not use `{}` but `()` when referencing variables in makefiles.
There is no continuation indentation here, please adjust.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2262972522
PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2262984228
