On Thu, 7 Aug 2025 00:24:10 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> How is it that we (Oracle) don't see these gtest death test failures in our > CI? I'm guessing others (like SAP - @tstuefe ?) aren't either, since this > issue is newly reported while the causing change was made more than 8 months > ago. > > The code in gtest-death-test-internal.h#L198-L212 referenced in the PR > description is conditionalized on GTEST_HAS_EXCEPTIONS, which leads me to > wonder why exceptions are enabled. If not for that, we wouldn't be in that > code. > > That led me to wonder why, on Windows, we build libgtest and rebuild libjvm > with exceptions enabled, by using -EHsc instead of no -EH option as done for > the non-gtest libjvm? > > https://github.com/openjdk/jdk/blame/f95af744b07a9ec87e2507b3d584cbcddc827bbd/make/hotspot/lib/CompileGtest.gmk#L71 > > https://github.com/openjdk/jdk/blame/f95af744b07a9ec87e2507b3d584cbcddc827bbd/make/hotspot/lib/CompileGtest.gmk#L101 > > That decision seems pretty old, like maybe from the initial introduction of > gtest. I haven't tracked down why, or whether the reasons are still valid. I > think it would be better to change that, assuming that's possible. > > I was concerned that this might effectively undo JDK-8185734, since the > suggestion in JBS was to conditionalize some code on GTEST_HAS_SEH being > true. But it looks like the actual change didn't do that. This all sounds very familiar; let me check. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26661#issuecomment-3166646532
