On Mon, 2 Jun 2025 16:39:20 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> `make bootcycle-images` broke after JDK-8349665, with the symptom: >> >> >> jdk.internal.md.interim/module-info.java:51: error: module not found: >> jdk.compiler.interim >> requires jdk.compiler.interim; >> >> >> This is since the bootcycle build use a special spec.gmk files which point >> to a special `make-support` directory, and this did not contain the >> necessary files needed to start running make targets. (Ever since >> JDK-8292944 they need to be explicitly generated.) > > make/Main.gmk line 429: > >> 427: ( cd $(TOPDIR) && \ >> 428: $(MAKE) $(MAKE_ARGS) -f make/GenerateFindTests.gmk \ >> 429: SPEC=$(BOOTCYCLE_SPEC)) > > Indentation looks a bit off here. Yeah, it was completely borked. Not only was there an extra space here, but I did not realize the opening parenthesis should set the base indentation level. Fixed now, thanks for noticing! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25594#discussion_r2121678143
