On Fri, 7 Mar 2025 15:11:09 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> So, Daniel pointed out some irrelevant changes that you tried to sneak in. :) > I think he is right that these should be reverted. I don't see anyone > complaining about removing `-Zc:wchar_t-` though, or the necessary follow-up > fixes for this. > > But this PR has indeed gotten a bit messy, so it's maybe better to open a new > and just bring over the relevant fixes. I don't think Daniel's concerns stopped at the irrelevant changes though. I recall he was worried about removing the switch causing everywhere a jchar is passed to a WINAPI method needing a reinterpret cast, which is dangerous. I still don't know if that concern has been addressed yet ------------- PR Comment: https://git.openjdk.org/jdk/pull/12907#issuecomment-2706705837
