On Wed, 19 Feb 2025 09:55:42 GMT, Ivan Bereziuk <d...@openjdk.org> wrote:
>> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#what-do-all-those-numbers-in-the-test-results-line-mean). >> >> Use the additional information in the "summary" block printed at the end of >> `make test` target. > > Ivan Bereziuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 11 additional > commits since the last revision: > > - Merge branch 'master' into 8343832_enhance_test_summary > - Merge branch 'master' into 8343832_enhance_test_summary > - SKIPPED is always zero for Microbenchark testing. Define SKIPPED in one go > after branching. > - _SKIPPED was not defined for gtest and special tests. Treat disabled > gtests as _SKIPPED > - adapt changes to the ancient awk on MacOS > - Merge branch 'master' into 8343832_enhance_test_summary > - indented the comment > - remove resorting zero-ing of $1_SKIPPED as preceding gawk always assigns > the value > - lowercased Jtreg. fixed typos in the comment > - aggregated calculation for many categoires of skipped tests into one gawk > block with regex > - ... and 1 more: https://git.openjdk.org/jdk/compare/1b30c128...6af586a2 The GHA tests all look failed since `.github/scripts/gen-test-summary.sh` does not know about this new output format. The fix should be fairly trivial, but a somewhat more interesting question is if the number of skipped tests should be reported to the user, not as an error but as a warning or informational message. On the one hand, it seems prudent to inform users that not all tests where run as requested, but on the other hand, most users likely don't care, they just want to run "tier1" with whatever it includes, and printing the number of skipped tests for all test runs will likely only produce clutter and noise. Actually, I think I answered myself. :-) We should not inform about skipped tests in GHA. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22245#issuecomment-2684787926
