On Thu, 23 Jan 2025 23:19:44 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> The devkit makefile is a public description on how Oracle builds the JDK in >> its CI system. This patch will update the devkit makefile to make Fedora 41 >> default for all platforms, and update the jib configuration to use devkits >> based on Fedora 41 and gcc 13.2. >> >> Also some additional fixes are needed to make this work: >> * `Winvalid-pch` is not as much a warning per se, as an extended diagnostic >> when gcc encounters PCH failures (which I did on PPC). I think it does not >> hurt to keep it on for all platforms. >> * gold seems mostly abandoned these days. :-( It fails to compile for two of >> the platforms, and produces a broken linker on the third. >> * libxcb is needed by libX11 on riscv64; technically it is not needed for >> the other architectures but I did not bother make an architecture-specific >> mechanism. >> * And Fedora riscv64 has finally been part of a proper release, so we can >> skip hardcoding a specific rawhide drop. >> * The strange edits in the clang part of the sharedRuntimeTrig etc >> exceptions is me replacing incorrect leading tabs with spaces. > > make/hotspot/lib/JvmOverrideFiles.gmk line 71: > >> 69: $(OPT_SPEED_SRC) \ >> 70: # >> 71: endif > > This looks to be in conflict with https://github.com/openjdk/jdk/pull/23268 Ah, I missed that one. This seems like a more conservative fix, but I can go with the one in https://github.com/openjdk/jdk/pull/23268 as well and revert this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23283#discussion_r1927834439
