On Tue, 21 Jan 2025 16:34:56 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is so that when `idea.sh` finally calls make again, we will get back to >> our configuration. Otherwise, if we have multiple configurations, `idea.sh` >> will fail since it can't single out a specific one. This will not show up on >> CI runs where we only have a single configuration, but can arise when >> running the test locally with several configurations. > > I thought that was about what I said in the comment, and I feel like I mostly > repeat myself. Can you suggest a better way to phrase it, if it is still not > clear enough? Suggestion: # Unset these variables to avoid having the current environment interfere with # the idea generation script. SPEC needs to remain as idea.sh will call back to # make and that call needs to have SPEC defined. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23200#discussion_r1924170617
