JavaCompilation.gmk includes ZipArchive.gmk, which includes ToolsJdk.gmk, which in turns includes JavaCompilation.gmk. This causes a circular dependency, which is not ideal. Make handles this anyway, but when I was developing new functionality to the build system, I discovered that this became a blocker.
Fortunately, the solution is simple. We include ZipArchive.gmk to support the convenience argument SRCZIP. It is used only in a single place, when compiling demos, and we can just as well (and arguably even better) call SetupZipArchive directly there. ------------- Commit messages: - 8347996: JavaCompilation.gmk should not include ZipArchive.gmk Changes: https://git.openjdk.org/jdk/pull/23175/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23175&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347996 Stats: 28 lines in 2 files changed: 8 ins; 17 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/23175.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23175/head:pull/23175 PR: https://git.openjdk.org/jdk/pull/23175
