On Fri, 8 Nov 2024 10:34:43 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> That's okay, I wasn't initially sure why they were changed. I'm looking at >> JRTArchiveFile.toEntry and wondering there should be a follow-up issue (not >> this PR) to fail early if running on a patched run-time even though it would >> be an odd configuration to attempt to do that. > > There already is. See: > https://github.com/openjdk/jdk/pull/14787/files#diff-b6b47eacb6060eb0a583a253f322f5d274063e082a12a72e8628a6e1ba6cdd3eR466-R471 > > It's also tested with > [PatchedJDKModuleJlinkTest.java](https://github.com/openjdk/jdk/pull/14787/files#diff-11b8a26307346fd7ca016a349243cabd3b982964aaf4335298e28e956b3968eb). > Do we need more? Yes, I know there is a test. It's "no such file" case in JRTArchiveFile.toEntry that I'm looking at. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1834151588
