On Wed, 30 Oct 2024 21:18:39 GMT, Severin Gehwolf <[email protected]> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line
>> 526:
>>
>>> 524: }
>>> 525: } catch (IOException e) {
>>> 526: throw new InternalError("Failed to process run-time image
>>> resources " +
>>
>> For unexpected exceptions, some code throws InternalError and some throws
>> AssertionError - better to be consistent and I think implementation
>> typically throws InternalError. For IOException, I think
>> `UncheckedIOException` is appropriate.
>
> I've changed it to AssertionError, but can change it to UncheckedIOException
> instead. Will take another pass on this issue tomorrow.
Having looked at this again the patch now consistently uses `AssertionError`
which should be fine? Please let me know if that's an issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1824220910
