On Wed, 30 Oct 2024 03:05:32 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Error in os_windows.cpp for unknown cpu > > src/hotspot/share/adlc/main.cpp line 494: > >> 492: } >> 493: >> 494: #if !defined(_WIN32) || defined(_WIN64) > > Removing the conditionalization is fine for this change. But see also > https://bugs.openjdk.org/browse/JDK-8342639 > I've added a note there that this change removed the conditionalization. I'm glad you're giving some TLC to adlc. It is in desperate need of it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822410201
