On Tue, 29 Oct 2024 09:21:39 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> On SUSE with precompiled binutils this error occurs : > > configure: error: "/mydir/binutils-2.39-s15/lib64 must contain libbfd.a, > libopcodes.a and libiberty.a" > > But the libs are present; the error message and detection is wrong. Looks good, just a minor style nit. make/autoconf/lib-hsdis.m4 line 270: > 268: disasm_header="\"$BINUTILS_INSTALL_DIR/include/dis-asm.h\"" > 269: if (test -e $BINUTILS_INSTALL_DIR/lib/libbfd.a || test -e > $BINUTILS_INSTALL_DIR/lib64/libbfd.a) && \ > 270: (test -e $BINUTILS_INSTALL_DIR/lib/libopcodes.a || test -e > $BINUTILS_INSTALL_DIR/lib64/libopcodes.a) && \ Could you break these lines to match the rest of the if condition? ------------- PR Review: https://git.openjdk.org/jdk/pull/21755#pullrequestreview-2401738881 PR Review Comment: https://git.openjdk.org/jdk/pull/21755#discussion_r1820718275
