On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java > CONF=linux-x86_64-server-release JTREG="JTREG_TEST_THREAD_FACTORY=Virtual" > > > Building target 'test' in configuration 'linux-x86_64-server-release' > JTREG_TEST_THREAD_FACTORY=Virtual is not a valid keyword for JTREG. > Valid keywords: JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT > VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT > REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS > EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS. > RunTests.gmk:206: *** Cannot continue. Stop. > > > So I think we should fix the document bug in `doc/testing.md` to avoid take > the same mistake. Trivial fix, no risk. This pull request has now been integrated. Changeset: cdad7286 Author: SendaoYan <s...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/cdad7286c6a099f5d0aa1f936e6201df9f3004cb Stats: 5 lines in 4 files changed: 0 ins; 0 del; 5 mod 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY Reviewed-by: ihse, erikj ------------- PR: https://git.openjdk.org/jdk/pull/21594
