On Thu, 19 Sep 2024 10:29:11 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JVMCI support
>
> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2529:
>
>> 2527: }
>> 2528: __ decode_klass_not_null(result);
>> 2529: } else {
>
> Could this if/else block be replaced with a simple call of load_klass(...)?
Yes, will do.
> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 3522:
>
>> 3520: {
>> 3521: __ movptr(result, Address(obj, oopDesc::klass_offset_in_bytes()));
>> 3522: }
>
> Could this if/else block be replaced with a simple call of load_klass(...)?
Yes, will do.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1766689169
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1766689004
