On Thu, 12 Sep 2024 11:46:35 GMT, Roberto Castañeda Lozano
<[email protected]> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental change of UCOH default
>
> src/hotspot/share/cds/filemap.cpp line 2457:
>
>> 2455: compressed_oops(),
>> compressed_class_pointers());
>> 2456: if (compressed_oops() != UseCompressedOops ||
>> compressed_class_pointers() != UseCompressedClassPointers) {
>> 2457: log_info(cds)("Unable to use shared archive.\nThe saved state of
>> UseCompressedOops and UseCompressedClassPointers is "
>
> The promotion of this CDS log line from `info` to `warning` triggers false
> failures in the `test/hotspot/jtreg/compiler/intrinsics/bmi` tests when
> running them with `-XX:-UseCompressedClassPointers`. These tests expect the
> standard output of different JVM runs to be identical, but the timestamps in
> the log messages tend to differ. I suggest adjusting the test configuration
> so that log timestamps are simply omitted, as in [this
> patch](https://github.com/robcasloz/jdk/commit/48f6e90ef6e0a71b55df536ed04a8b72130b5ea9)
> (feel free to merge it as-is or with any further changes you may find
> necessary).
This comment has been marked as "resolved" without any apparent action being
taken, is that intentional?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1758369787
