On Tue, 25 Jun 2024 23:24:59 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> since the last revision: >> >> - Merge branch 'master' into 8309634-resolve-methods-at-dumptime >> - @calvinccheung and @matias9927 comments >> - Fixed whitespaces >> - 8309634: Resolve CONSTANT_MethodRef at CDS dump time > > src/hotspot/share/interpreter/interpreterRuntime.cpp line 671: > >> 669: >> 670: // check if link resolution caused cpCache to be updated >> 671: ConstantPoolCache* cache = pool->cache(); > > Is this needed? I don't see `cache` being used within the function. I removed this line. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19866#discussion_r1653862864
