On Tue, 28 May 2024 02:39:01 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into hotspot-assembler-functions >> - Fix copyright headers >> - Fix building on macos/aarch64 >> - Use % instead of @ due to arm assembler >> - 8331921: Hotspot assembler files should use common logic to setup >> exported functions > > make/hotspot/lib/CompileJvm.gmk line 53: > >> 51: >> -I$(TOPDIR)/src/hotspot/os_cpu/$(HOTSPOT_TARGET_OS)_$(HOTSPOT_TARGET_CPU_ARCH) >> \ >> 52: -I$(TOPDIR)/src/hotspot/os/$(HOTSPOT_TARGET_OS) \ >> 53: -I$(TOPDIR)/src/hotspot/os/$(HOTSPOT_TARGET_OS_TYPE) \ > > What does the second line evaluate to on Windows? Does it duplicate the prior > line? Yes, it does. It is a bit unfortunate, but it is also hard to avoid with the limited expressions that are available in Make syntax. (It can be done but at the cost of decreased readability.) It is completely harmless, though, and we have the same construct in other places in the build system. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19138#discussion_r1617044188
