> This is a patch that:
> a) upgrades the JLine inside the JDK to 3.25.1
> b) since the new version of JLine has a FFM backend, our custom native 
> backends are removed, and replaced with the FFM backend
> 
> Some changes had to be made to the original JLine in order to fit into the 
> JDK. Most of them were already done for the previous version (repackaging, 
> avoiding non-ASCII characters, commenting out logging, adding ability to 
> modify to wrap the InputStream used by the terminal), and have only been 
> transferred to the new one. The main two new changes are:
> - fixes to the FFM backend, so that it works on Linux and JDK 22. These have 
> been proposed to JLine itself: https://github.com/jline/jline3/pull/945
> - disabling the `NativeFileDescriptorCreator`, as I believe we don't need it, 
> and cannot make it work easily
> 
> There's a full patch between the 
> `src/jdk.internal.le/share/classes/jdk/internal/org` and the merged content 
> of the corresponding sources of these original JLine sub-projects:
> https://github.com/jline/jline3/tree/jline-parent-3.25.1/reader
> https://github.com/jline/jline3/tree/jline-parent-3.25.1/terminal-ffm
> https://github.com/jline/jline3/tree/jline-parent-3.25.1/terminal
> the patch is here:
> https://cr.openjdk.org/~jlahoda/8327476/jline-3.25.1-upgrade.diff
> 
> I've also cleaned the patch a little removing most of the changes for the 
> rename. The result is here:
> https://cr.openjdk.org/~jlahoda/8327476/jline-3.25.1-upgrade-significant.diff

Jan Lahoda has updated the pull request incrementally with one additional 
commit since the last revision:

  Removing trailing whitespace.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18142/files
  - new: https://git.openjdk.org/jdk/pull/18142/files/01f95c42..9f6509a9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18142&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18142&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18142.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18142/head:pull/18142

PR: https://git.openjdk.org/jdk/pull/18142

Reply via email to