On Wed, 10 Apr 2024 10:07:02 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Is the comment in front of >> https://github.com/openjdk/jdk/blob/51ed69a586105b707ae616f9eba898449bf9fba7/src/hotspot/os/aix/os_aix.cpp#L28 >> still correct? Seems like it should get replaced. See >> https://www.ibm.com/docs/en/openxl-c-and-cpp-aix/17.1.1?topic=pragmas-pragma-alloca-c-only > > Can `-Dalloca=__builtin_alloca` replace `#include <alloca.h>`? Yes I believe. I will remove the `#pragma alloca` everywhere, I will remove the `#include <alloca.h>` everywhere and I will add `-Dalloca=__builtin_alloca` to the compile commands. If it works I will update the PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1559191851
