> This patch will fix the few remaining places where a "raw" call to > SetupNativeCompilation was made, instead of going via > SetupJdkNativeCompilation. This include repairing the poor old X11Wrapper, > which has been broken for some time. > > After this we can finally make SetupNativeCompilation an "inner macro" of > SetupJdkNativeCompilation, and stop exposing two different ways of compiling > native code. > > I have also added standard header comments to some places where I have missed > it, and corrected an incorrect indentation (all things I found while > double-checking all SetupJdkNativeCompilation calls).
Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision: - Update documentation - Do not add LIBCXX for tests - Add ability to disable DEFAULT_VERSIONINFO_RESOURCE ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18631/files - new: https://git.openjdk.org/jdk/pull/18631/files/a592e19f..ecd86477 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18631&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18631&range=00-01 Stats: 15 lines in 3 files changed: 11 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18631.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18631/head:pull/18631 PR: https://git.openjdk.org/jdk/pull/18631