On Thu, 29 Feb 2024 12:23:37 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> After we removed mapfiles, we can setup -fvisibility=hidden (and > -Wl,--exclude-libs,ALL) in the most basic flags, so this applies to all > compilation. > > This will remove duplicate code and make the underlying assumptions of the > build clearer. > > Doing this will result in the same output result -- with one exception: > native test libraries has not been compiled with this flag (and this caused > an error for a Oracle-internal test). Marked as reviewed by jwaters (Committer). make/autoconf/flags-ldflags.m4 line 85: > 83: > 84: if test "x$OPENJDK_TARGET_OS" = xlinux; then > 85: BASIC_LDFLAGS="-Wl,--exclude-libs,ALL" Duplicated code? It already adds -Wl,--exclude-libs,ALL above if the compiler is gcc ------------- PR Review: https://git.openjdk.org/jdk/pull/18061#pullrequestreview-1908903139 PR Review Comment: https://git.openjdk.org/jdk/pull/18061#discussion_r1507599902
