On Fri, 23 Feb 2024 13:54:36 GMT, Erik Joelsson <[email protected]> wrote:
> > I just realized I could keep an extremely simplified linker script
> > ("mapfile") for gcc, and thereby keeping the `@SUNWprivate_1.1` on the
> > exported symbols, and keeping `__bss_start` and friends local. This further
> > minimizes the difference to the existing libjvm.so for gcc builds.
>
> Why do this just for GCC? Shouldn't this be for Linux as we are doing it for
> backwards compatibility with user JNI libraries.
Good point. I did not really consider the case of clang on linux, since this is
a secondary option, and I did not believe keeping consistency there was
important. But as you say, the fix is trivial and makes a lot of sense. I have
now verified that the symbols look identical when compiling with clang, between
this PR and the latest (and hopefully last!) update, and mainline.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17955#issuecomment-1964720104
