On Fri, 23 Feb 2024 12:38:56 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Great. The only remaining difference I see is that the PR adds the following
> export:
>
> ```
> _ZGRN14AsyncLogWriter4NoneE_@@SUNWprivate_1.1
> ```
>
> Any idea what it might be? If not, I guess we can live with that.
No. I vaguely recognize this symbol as sticking out, but can't find it now in
my runs. Which gcc version are you using?
I think this is another example of the gcc bug. `c++filt` says `reference
temporary #0 for AsyncLogWriter::None`; I guess this is from
`logAsyncWriter.cpp` line 47-49:
// LogDecorator::None applies to 'constant initialization' because of its
constexpr constructor.
const LogDecorations& AsyncLogWriter::None = LogDecorations(LogLevel::Warning,
LogTagSetMapping<LogTag::__NO_TAG>::tagset(),
LogDecorators::None);
But I think we can live with that anyway, even if it gets exported for some gcc
versions after this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17955#issuecomment-1963855021
