On Thu, 22 Feb 2024 22:18:59 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove jvmci globals
>
> src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 122:
>
>> 120: }
>> 121:
>> 122: void das1(uintptr_t insn) {
>
> Doesn't this need to be exported for debugging on Windows-Aarch64?
Ah, right, there is a Windows/aarch64 port. Forgot about it. :(
I don't know who maintains/cares about that port anymore. Pinging @mo-beck
@lewurm @luhenry. Do anyone of you care about this anymore? If not, do you know
if anyone has taken up the baton? (Or maybe it's time to retire the
Windows/aarch64 port)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1500517200
