On Fri, 10 Nov 2023 01:25:32 GMT, Hao Sun <hao...@openjdk.org> wrote:
>> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment for stringop-overflow warning >> >> Co-authored-by: Hao Sun <hao....@arm.com> > > make/hotspot/lib/CompileJvm.gmk line 93: > >> 91: ifeq ($(DEBUG_LEVEL), fastdebug) >> 92: ifeq ($(call And, $(call isTargetOs, linux) $(call isTargetCpu, >> aarch64)), true) >> 93: DISABLED_WARNINGS_gcc += stringop-overflow > > Do you think it would be better if we add some comments here? > Suggestion: > > # False positive warnings for atomic_linux_aarch64.hpp on GCC >= 13 > DISABLED_WARNINGS_gcc += stringop-overflow I was also surprised to see the `dangling-pointer` warning just disappear, but I guess I'll take the win. Thank you for the code suggestion. We have not been consistent when it comes to (not) adding comments to the disabled warnings but perhaps this is a good time to start. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16584#discussion_r1389718228
