On Tue, 31 Oct 2023 06:39:55 GMT, Robbin Ehn <r...@openjdk.org> wrote:

> I think you are correct, I tested on some more machines.
> 
> On my vf2 dev board (4-core rv64) it do speed up sh configure, from 7:19 to 
> 3:40. I see like 20 instances of cc1 instead 1, a bit to many.... :)

Adding the `-j` flag without a number tells make to figure it out itself, which 
can lead to massive amounts of processes. Depending on the makefile, that can 
still work ok in many cases, but should probably not be applied by default.

> I'll close PR and leave enhancement open! Thanks for having a look!

Ok, I don't think moving `BPERF_SETUP_BUILD_JOBS` to before the libraries 
section is very controversial. Just include a comment explaining that it may be 
needed for more efficient library detection.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16421#issuecomment-1787163116

Reply via email to