On Mon, 31 Jul 2023 04:51:12 GMT, David Holmes <[email protected]> wrote:
>> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Try not to remove CCACHE_BASEDIR. > > make/autoconf/build-performance.m4 line 246: > >> 244: fi >> 245: >> 246: if $ALLOW_ABSOLUTE_PATHS_IN_OUTPUT;then > > Does this even build? Surely you need `if test ...` here? It works fine, I did test it. make/autoconf/jdk-options.m4: ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="false" make/autoconf/jdk-options.m4: ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="true" make/autoconf/jdk-options.m4: ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="false" make/autoconf/jdk-options.m4: ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="true" I see other code is using the test: make/autoconf/flags-cflags.m4: if test "x$ALLOW_ABSOLUTE_PATHS_IN_OUTPUT" = "xfalse"; then So I will change it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1278795159
