On Thu, 1 Jun 2023 14:27:12 GMT, Thomas Stuefe <[email protected]> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Force PLAB sizes to align on card-table size
>
> test/hotspot/jtreg/gc/shenandoah/oom/TestClassLoaderLeak.java line 132:
>
>> 130: {{"iu"}, {"adaptive", "aggressive"}},
>> 131: {{"passive"}, {"passive"}},
>> 132: {{"generational"}, {"adaptive"}}
>
> Curious, here and in similar places, why only test adaptive heuristic for
> generational, if we test satb with all variants?
Generational mode only works with adaptive heuristic.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1213863860
