On Mon, 27 Feb 2023 15:14:22 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 132: > >> 130: # that any cleanup of code related to AWT will not change the >> 131: # generated code and cause performance issues in J2DBench >> 132: LIBAWT_CFLAGS += -fpic > > We compile with `-fPIC` as a standard flag for position independent code (I > just verified that LIBAWT also gets this flag today). My understanding is > that `-fpic` may result in smaller/faster code. Overriding with `-fpic` seems > like its helping here, but the comment needs to be fixed to explain the > actual difference and reason. Thanks @erikj79 for your inputs. I have updated the comment to be relevant to the problem it is resolving. ------------- PR: https://git.openjdk.org/jdk/pull/12761
