On Thu, 16 Feb 2023 19:08:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is a retake on https://github.com/openjdk/jdk/pull/12461. Changes > compared to the original patch: > > Both WriteFile and AppendFile are fixed. > > It turned out we actually did a `$(strip)` on the input for the `$(file)` > variant, so for consistency we should do that for the make 3.81 as well. > Almost as a side-effect, this will also handle the problem of risking to add > multiple newlines, since any trailing newlines will be removed by the strip, > and then we can always append a newline. > > Unit tests are added. I have verified functionality on make 3.81, 4.0 and 4.4. This pull request has now been integrated. Changeset: a39cf2e3 Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/a39cf2e3b242298fbf5fafdb8aa9b5d4562061ef Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/12605
