On Fri, 2 Sep 2022 17:16:42 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Cleaned up header files
>
> src/hotspot/share/cds/archiveHeapLoader.cpp line 58:
> 
>> 56: #include "oops/oop.inline.hpp"
>> 57: #include "oops/typeArrayOop.inline.hpp"
>> 58: #include "prims/jvmtiExport.hpp"
> 
> It looks like you should be able to remove a lot of these header files.

Thanks for the review. I took out the unnecessary includes in the four affected 
files {heapShared,archiveHeapLoader}.{cpp,hpp}. As a result, I had to fix a few 
other files to add missing header files that were included transitively.

-------------

PR: https://git.openjdk.org/jdk/pull/10138

Reply via email to