thanks, committed.

On 2024/10/18 11:18, Martin Ziemer wrote:
> Am Thu, Oct 17, 2024 at 11:21:08AM -0500 schrieb m...@techautonomy.net:
> > >Synopsis:  smartmontools package /etc/smartd_warning.sh has incorrect file 
> > >permissions
> > >Environment:
> >     System      : OpenBSD 7.6
> >     Architecture: OpenBSD.amd64
> >     Machine     : amd64
> >
> > >Description:
> >     I'm trying to send emails for disk errors using the smartmontools
> >     package. For this to work, the script /etc/smartd_warning.sh has to be
> >     executable. However, the port has mode 644 on this file.
> >
> > >How-To-Repeat:
> >     Put this in /etc/smartd.conf and run 'rcctl restart smartd':
> >     DEVICESCAN -m m...@techautonomy.net -M test
> >
> >     Per the documentation this is supposed to send a test email to you. On 
> > OpenBSD
> >     it doesn't work due to a the file permissions on smartd_warning.sh
> > >Fix:
> >     chmod 755 /etc/smartd_warning.sh
> 
> I just tested on my amd64 system and got the same problem.
> 
> The patch below fixes it (on two amd64 systems here) by specifically setting 
> the correct rights.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/smartmontools/Makefile,v
> retrieving revision 1.51
> diff -u -p -u -p -r1.51 Makefile
> --- Makefile  27 May 2024 14:30:36 -0000      1.51
> +++ Makefile  18 Oct 2024 09:13:24 -0000
> @@ -2,7 +2,7 @@ COMMENT=              control and monitor storage sy
>  
>  # XXX at update time check whether C++11 is actually needed
>  DISTNAME=            smartmontools-7.4
> -REVISION=            0
> +REVISION=            1
>  CATEGORIES=          sysutils
>  
>  HOMEPAGE=            https://www.smartmontools.org/
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/sysutils/smartmontools/pkg/PLIST,v
> retrieving revision 1.10
> diff -u -p -u -p -r1.10 PLIST
> --- pkg/PLIST 17 Nov 2022 09:48:09 -0000      1.10
> +++ pkg/PLIST 18 Oct 2024 09:13:24 -0000
> @@ -26,4 +26,5 @@ share/examples/smartmontools/Example7
>  share/examples/smartmontools/Example8
>  share/examples/smartmontools/README
>  share/examples/smartmontools/smartd_warning.sh
> +@mode 0755
>  @sample ${SYSCONFDIR}/smartd_warning.sh
> 

Reply via email to