>Synopsis:      skey command does not display all possible one-time passwords
>Category:      user
>Environment:
        System      : OpenBSD 7.5
        Details     : OpenBSD 7.5-current (GENERIC.MP) #207: Mon Jul 22 
21:40:56 MDT 2024
                         
dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP

        Architecture: OpenBSD.amd64
        Machine     : amd64
>Description:
You can't display all (from 0 to SKEY_MAX_SEQ (10000)) one-time passwords
with the skey, otp-md5, otp-rmd160 or otp-sha1 commands.

>How-To-Repeat:
$ skey -p coucou -n 9999 10000 plop | head -n 3
2: NAME ECHO FOUR ALL SAP RAT
3: DOE GYP COCA KURT ELY NIBS
4: WEE AIDA DAM COIL GRUB MINK

but

$ skey -p coucou -n 10000 10000 plop | head -n 3
usage: skey [-x] [-md5 | -rmd160 | -sha1] [-n count]
        [-p passphrase] <sequence#>[/] key
>Fix:
Line 63 of usr.bin/skey/skey.c, I think it's not:

cnt = strtonum(argv[i], 1, SKEY_MAX_SEQ -1, &errstr);

but

cnt = strtonum(argv[i], 1, SKEY_MAX_SEQ +1, &errstr);

Which results in:
$ ./my_skey -p coucou -n 10001 10000 plop | head -n 3
0: ARM MESH SOUL SELF LADY EDGE
1: IBIS GALL DAME GAB DAYS BITE
2: NAME ECHO FOUR ALL SAP RAT


dmesg:
OpenBSD 7.5-current (GENERIC.MP) #207: Mon Jul 22 21:40:56 MDT 2024
    dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 14918193152 (14227MB)
avail mem = 14442754048 (13773MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 3.3 @ 0xcd027000 (45 entries)
bios0: vendor American Megatrends International, LLC. version "5.09" date 
03/31/2023
bios0: Micro Computer (HK) Tech Limited UM560 XT
efi0 at bios0: UEFI 2.7
efi0: American Megatrends rev 0x50013
acpi0 at bios0: ACPI 6.2
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP MSDM SSDT IVRS SSDT FIDT MCFG HPET FPDT VFCT BGRT TPM2 
SSDT CRAT CDIT SSDT SSDT SSDT SSDT WSMT APIC SSDT SSDT
acpi0: wakeup devices GPP0(S4) GPP1(S4) GPP2(S4) GPP3(S4) GPP4(S4) GPP5(S4) 
GP17(S4) XHC0(S4) XHC1(S4) GP18(S4) GP19(S4) SIO1(S3)
acpitimer0 at acpi0: 3579545 Hz, 32 bits
acpimcfg0 at acpi0
acpimcfg0: addr 0xf0000000, bus 0-127
acpihpet0 at acpi0: 14318180 Hz
acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu0: cpuid 1 
edx=178bfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT>
 
ecx=76d8320b<SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND>
cpu0: cpuid 6 eax=4<ARAT> ecx=1<EFFFREQ>
cpu0: cpuid 7.0 
ebx=219c97a9<FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA>
 ecx=40068c<UMIP,PKU> edx=10
cpu0: cpuid d.1 eax=f<XSAVEOPT,XSAVEC,XGETBV1,XSAVES>
cpu0: cpuid 80000001 edx=2fd3fbff<NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG> 
ecx=75c237ff<LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX>
cpu0: cpuid 80000007 edx=6799<HWPSTATE,ITSC>
cpu0: cpuid 80000008 
ebx=191ef657<IBPB,IBRS,STIBP,STIBP_ALL,IBRS_PREF,IBRS_SM,SSBD>
cpu0: cpuid 8000001F 
eax=1780f<SME,SEV,PFLUSH_MSR,SEVES,REQ64BITHOST,RESTINJ,ALTINJ,DBGSTSW,VTE> 
edx=1
cpu0: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 
8-way L2 cache, 16MB 64b/line 16-way L3 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 100MHz
cpu0: mwait min=64, max=64, C-substates=1.1, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: AMD Ryzen 5 5600H with Radeon Graphics, 3300.01 MHz, 19-50-00, patch 
0a50000d
cpu3: smt 1, core 1, package 0
cpu4 at mainbus0: apid 4 (application processor)
cpu4: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu4: smt 0, core 2, package 0
cpu5 at mainbus0: apid 5 (application processor)
cpu5: AMD Ryzen 5 5600H with Radeon Graphics, 3300.02 MHz, 19-50-00, patch 
0a50000d
cpu5: smt 1, core 2, package 0
cpu6 at mainbus0: apid 6 (application processor)
cpu6: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu6: smt 0, core 3, package 0
cpu7 at mainbus0: apid 7 (application processor)
cpu7: AMD Ryzen 5 5600H with Radeon Graphics, 3300.01 MHz, 19-50-00, patch 
0a50000d
cpu7: smt 1, core 3, package 0
cpu8 at mainbus0: apid 8 (application processor)
cpu8: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu8: smt 0, core 4, package 0
cpu9 at mainbus0: apid 9 (application processor)
cpu9: AMD Ryzen 5 5600H with Radeon Graphics, 3300.01 MHz, 19-50-00, patch 
0a50000d
cpu9: smt 1, core 4, package 0
cpu10 at mainbus0: apid 10 (application processor)
cpu10: AMD Ryzen 5 5600H with Radeon Graphics, 3300.00 MHz, 19-50-00, patch 
0a50000d
cpu10: smt 0, core 5, package 0
cpu11 at mainbus0: apid 11 (application processor)
cpu11: AMD Ryzen 5 5600H with Radeon Graphics, 3300.02 MHz, 19-50-00, patch 
0a50000d
cpu11: smt 1, core 5, package 0
ioapic0 at mainbus0: apid 33 pa 0xfec00000, version 21, 24 pins, can't remap
ioapic1 at mainbus0: apid 34 pa 0xfec01000, version 21, 32 pins, can't remap
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus -1 (GPP0)
acpiprt2 at acpi0: bus -1 (GPP1)
acpiprt3 at acpi0: bus 1 (GPP2)
acpiprt4 at acpi0: bus 2 (GPP3)
acpiprt5 at acpi0: bus 3 (GPP4)
acpiprt6 at acpi0: bus -1 (GPP5)
acpiprt7 at acpi0: bus -1 (GPP6)
acpiprt8 at acpi0: bus 4 (GP17)
acpiprt9 at acpi0: bus 5 (GP18)
acpiprt10 at acpi0: bus -1 (GP19)
acpipci0 at acpi0 PCI0: 0x00000010 0x00000011 0x00000000
acpicmos0 at acpi0
com0 at acpi0 UAR1 addr 0x3f8/0x8 irq 4: ns16550a, 16 byte fifo
acpibtn0 at acpi0: PWRB
"ACPI0010" at acpi0 not configured
acpicpu0 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu1 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu2 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu3 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu4 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu5 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu6 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu7 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu8 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu9 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu10 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
acpicpu11 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS
amdgpio0 at acpi0 GPIO uid 0 addr 0xfed81500/0x400 irq 7, 184 pins
"PNP0C50" at acpi0 not configured
"PNP0C50" at acpi0 not configured
"NXP8013" at acpi0 not configured
"CPLM3218" at acpi0 not configured
tpm0 at acpi0 TPM_: unsupported TPM2 start method 2
"PNP0C14" at acpi0 not configured
acpipwrres0 at acpi0: P0SA, resource for SATA
acpipwrres1 at acpi0: P0SA, resource for SAT1
acpivideo0 at acpi0: VGA_
acpivout0 at acpivideo0: LCD_
cpu0: 3300 MHz: speeds: 3300 1300 1200 MHz
pci0 at mainbus0 bus 0
ksmn0 at pci0 dev 0 function 0 "AMD 17h/6xh Root Complex" rev 0x00
"AMD 17h/6xh IOMMU" rev 0x00 at pci0 dev 0 function 2 not configured
pchb0 at pci0 dev 1 function 0 "AMD 17h/6xh Host" rev 0x00
ppb0 at pci0 dev 1 function 3 "AMD 17h/6xh PCIE" rev 0x00: msi
pci1 at ppb0 bus 1
igc0 at pci1 dev 0 function 0 "Intel I225-V" rev 0x03, msix, 4 queues, address 
58:47:ca:71:61:59
pchb1 at pci0 dev 2 function 0 "AMD 17h/6xh Host" rev 0x00
ppb1 at pci0 dev 2 function 1 "AMD 17h/6xh PCIE" rev 0x00: msi
pci2 at ppb1 bus 2
"MediaTek MT7921K" rev 0x00 at pci2 dev 0 function 0 not configured
ppb2 at pci0 dev 2 function 2 "AMD 17h/6xh PCIE" rev 0x00: msi
pci3 at ppb2 bus 3
nvme0 at pci3 dev 0 function 0 vendor "Phison", unknown product 0x5013 rev 
0x01: msix, NVMe 1.3
nvme0: ESO512GYLCT-EP3-2L, firmware EDFME0.1, serial 511230607199001012
scsibus1 at nvme0: 2 targets, initiator 0
sd0 at scsibus1 targ 1 lun 0: <NVMe, ESO512GYLCT-EP3-, EDFM>
sd0: 488386MB, 512 bytes/sector, 1000215216 sectors
pchb2 at pci0 dev 8 function 0 "AMD 17h/6xh Host" rev 0x00
ppb3 at pci0 dev 8 function 1 "AMD 17h/6xh PCIE" rev 0x00
pci4 at ppb3 bus 4
amdgpu0 at pci4 dev 0 function 0 "ATI Cezanne" rev 0xc6
drm0 at amdgpu0
amdgpu0: msi
azalia0 at pci4 dev 0 function 1 "ATI Renoir HD Audio" rev 0x00: msi
azalia0: no supported codecs
ccp0 at pci4 dev 0 function 2 "AMD 17h/1xh Crypto" rev 0x00: msix: RNG
xhci0 at pci4 dev 0 function 3 "AMD 17h/6xh xHCI" rev 0x00: msix, xHCI 1.10
usb0 at xhci0: USB revision 3.0
uhub0 at usb0 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 
addr 1
xhci1 at pci4 dev 0 function 4 "AMD 17h/6xh xHCI" rev 0x00: msix, xHCI 1.10
usb1 at xhci1: USB revision 3.0
uhub1 at usb1 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 
addr 1
"AMD 17h/1xh I2S Audio" rev 0x01 at pci4 dev 0 function 5 not configured
azalia1 at pci4 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi
azalia1: codecs: Conexant/0x1f86
audio0 at azalia1
vendor "AMD", unknown product 0x15e4 (class DASP subclass miscellaneous, rev 
0x00) at pci4 dev 0 function 7 not configured
ppb4 at pci0 dev 8 function 2 "AMD 17h/6xh PCIE" rev 0x00
pci5 at ppb4 bus 5
ahci0 at pci5 dev 0 function 0 "AMD FCH AHCI" rev 0x81: msi, AHCI 1.3.1
ahci0: port 1: 6.0Gb/s
scsibus2 at ahci0: 32 targets
sd1 at scsibus2 targ 1 lun 0: <ATA, Samsung SSD 870, SVQ0> naa.5002538f41b245d5
sd1: 953869MB, 512 bytes/sector, 1953525168 sectors, thin
ahci1 at pci5 dev 0 function 1 "AMD FCH AHCI" rev 0x81: msi, AHCI 1.3.1
scsibus3 at ahci1: 32 targets
piixpm0 at pci0 dev 20 function 0 "AMD FCH SMBus" rev 0x51: polling
iic0 at piixpm0
iic1 at piixpm0
pcib0 at pci0 dev 20 function 3 "AMD FCH LPC" rev 0x51
pchb3 at pci0 dev 24 function 0 "AMD 19h/5xh Data Fabric" rev 0x00
pchb4 at pci0 dev 24 function 1 "AMD 19h/5xh Data Fabric" rev 0x00
pchb5 at pci0 dev 24 function 2 "AMD 19h/5xh Data Fabric" rev 0x00
pchb6 at pci0 dev 24 function 3 "AMD 19h/5xh Data Fabric" rev 0x00
pchb7 at pci0 dev 24 function 4 "AMD 19h/5xh Data Fabric" rev 0x00
pchb8 at pci0 dev 24 function 5 "AMD 19h/5xh Data Fabric" rev 0x00
pchb9 at pci0 dev 24 function 6 "AMD 19h/5xh Data Fabric" rev 0x00
pchb10 at pci0 dev 24 function 7 "AMD 19h/5xh Data Fabric" rev 0x00
isa0 at pcib0
isadma0 at isa0
com1 at isa0 port 0x2f8/8 irq 3: ns16550a, 16 byte fifo
pckbc0 at isa0 port 0x60/5 irq 1 irq 12
pckbd0 at pckbc0 (kbd slot)
wskbd0 at pckbd0: console keyboard
pcppi0 at isa0 port 0x61
spkr0 at pcppi0
vmm0 at mainbus0: SVM/RVI
efifb at mainbus0 not configured
uhub2 at uhub0 port 2 configuration 1 interface 0 "VIA Labs, Inc. USB2.0 Hub" 
rev 2.10/7.f4 addr 2
uhidev0 at uhub2 port 2 configuration 1 interface 0 "Cherry Mikroschalter 
product 0x0023" rev 2.00/2.20 addr 3
uhidev0: iclass 3/1
ukbd0 at uhidev0: 8 variable keys, 6 key codes
wskbd1 at ukbd0 mux 1
uhidev1 at uhub2 port 2 configuration 1 interface 1 "Cherry Mikroschalter 
product 0x0023" rev 2.00/2.20 addr 3
uhidev1: iclass 3/0, 2 report ids
ucc0 at uhidev1 reportid 1: 1024 usages, 20 keys, array
wskbd2 at ucc0 mux 1
uhid0 at uhidev1 reportid 2: input=1, output=0, feature=0
uhub3 at uhub0 port 6 configuration 1 interface 0 "VIA Labs, Inc. USB3.1 Hub" 
rev 3.20/7.f4 addr 4
ugen0 at uhub1 port 3 "MediaTek Inc. Wireless_Device" rev 2.10/1.00 addr 2
vscsi0 at root
scsibus4 at vscsi0: 256 targets
softraid0 at root
scsibus5 at softraid0: 256 targets
root on sd0a (49c4b09ba9a27680.a) swap on sd0b dump on sd0b
amdgpu0: GREEN_SARDINE GC 9.3.0 7 CU rev 0x00
amdgpu0: 800x480, 32bpp
wsdisplay0 at amdgpu0 mux 1: console (std, vt100 emulation), using wskbd0
wskbd1: connecting to wsdisplay0
wskbd2: connecting to wsdisplay0
wsdisplay0: screen 1-5 added (std, vt100 emulation)

usbdevs:
Controller /dev/usb0:
addr 01: 1022:0000 AMD, xHCI root hub
         super speed, self powered, config 1, rev 1.00
         driver: uhub0
addr 02: 2109:2822 VIA Labs, Inc., USB2.0 Hub
         high speed, self powered, config 1, rev 7.f4, iSerial 000000001
         driver: uhub2
addr 03: 046a:0023 Cherry Mikroschalter, product 0x0023
         low speed, power 100 mA, config 1, rev 2.20
         driver: uhidev0
         driver: uhidev1
addr 04: 2109:0822 VIA Labs, Inc., USB3.1 Hub
         super speed, self powered, config 1, rev 7.f4, iSerial 000000001
         driver: uhub3

Reply via email to