Mark Kettenis wrote:
>> +#ifndef _MODE_T_DEFINED_
>> +#define _MODE_T_DEFINED_
>> +typedef __mode_t    mode_t;
>> +#endif
>
> It may be safer to drop this bit...
> 
>> +void         strmode(mode_t, char *);
> ...and use __mode_t in the prototype and implementation.

Someone including <string.h> might expect mode_t to be defined without
having to include another header.

However, no standard requires that and it seems strmode is the only
function that uses it. So if it is too much of an inconvenience I
wouldn't stress about it.

Collin

Reply via email to