On Sun, Sep 17, 2023 at 04:51:11PM +0200, Peter J. Philipp wrote: > On Sun, Sep 17, 2023 at 04:22:14PM +0200, Mark Kettenis wrote: > > > Date: Sun, 17 Sep 2023 12:40:29 +0200 > > > From: "Peter J. Philipp" <p...@delphinusdns.org> > > > > Sorry Peter, > > > > But this doesn't make any sense to me. Your C code is just as > > unreadable as the assembly code ;) > > Yeah it should be torn out and replaced. I have some replacemnent code > if you're willing to touch it with a 10 foot stick. Only.. it doesn't > work (yet) and I haven't gotten the idea yet as to why.
FYI, I have finished my work on making a generic asm function for page tables in locore.S, it may be overkill though but could be handy for the future. I've committed it to my MANGOPI branch and if you like it you can steal it. I don't expect this to be in OpenBSD if you don't like it ;). https://github.com/pbug44/openbsd-src/commit/b3a1c1206ddc7769233f00f0f5c1780666b78682 BTW I'm not an asm pro. I'm a newbie having only started with asm much since 2019 on powerpc. So I'm willing to share that this took me 10 days to get to where it is today, though not all days I was working on it, but close. I also refactored it completely about 3 or 4 times. Best Regards, -peter
