On Wed, Oct 26, 2022 at 09:51:36AM +1100, ja...@tubnor.net wrote:
> For a new project, we are trying a Lenovo Thinkstation M70s Gen 3 running
> OpenBSD. We hit a hurdle straight up when validating the hardware, the
> kernel doesn't get past the ACPI initialisation. Specifically:
>
> acpi0: at bios0: ACPI 6.4Could not convert 1 to 4
>
> panic: aml_die aml_convert:2095
>
> The operating system has halted.
> Please press any key to reboot.
>
> Whole kernel banner can be seen here:
> https://pbs.twimg.com/media/Ff8ilONakAMI6gQ?format=jpg
>
> Running 7.2-current (20221024)
>
> Sorry, there isn't much extra information I can give. The usual secure boot
> is off. FWIW, the machine was shipped from Lenovo with Ubuntu
> pre-installed.
On Friday I sent inlined patch to the OP, but still haven't received any
response, maybe the mail found its way into spam folder or something
else.
Wasn't able to test it, since I don't own the hardware and of course
there could be more issues even if that one is fixed with the patch.
I think it'd be good to have the patch for archives, in case anyone
google the error message.
diff /usr/src
commit - ba77ede935ace61278da5c3474c6951e0a606318
path + /usr/src
blob - 1a5694c9e4b77cd1223f26d81d8e3c11fd341adb
file + sys/dev/acpi/dsdt.c
--- sys/dev/acpi/dsdt.c
+++ sys/dev/acpi/dsdt.c
@@ -2035,6 +2035,16 @@ aml_convert(struct aml_value *a, int ctype, int clen)
return a;
}
switch (ctype) {
+ case AML_OBJTYPE_PACKAGE:
+ dnprintf(10,"convert to package\n");
+ switch (a->type) {
+ case AML_OBJTYPE_INTEGER:
+ c = aml_allocvalue(AML_OBJTYPE_PACKAGE, 1, NULL);
+ _aml_setvalue(c->v_package[0], AML_OBJTYPE_INTEGER,
+ a->v_integer, NULL);
+ break;
+ }
+ break;
case AML_OBJTYPE_BUFFER:
dnprintf(10,"convert to buffer\n");
switch (a->type) {
