On Sun, Mar 09, 2025 at 05:18:28PM +0000, Gavin Smith wrote: > On Sun, Mar 09, 2025 at 05:44:18PM +0100, Patrice Dumas wrote: > > I have not fully investigated, I could have a more thorough look, but I > > now get a test failing, languages/command_translated, with error→ > > becoming erreur→, in headers. Not with TEXINFO_XS=omit. I would not > > have expected that issue, as the language is in the caching hash, but > > still it could be linked to this commit, or the next one. > > I updated the test results by going to tta/perl and running > "../maintain/all_tests.sh generate". I then checked by running "make check". > > Both "TEXINFO_XS=required perl -w t/languages.t" and "TEXINFO_XS=omit > perl -w t/languages.t" passed for me. > > Howevever, then after I ran "make", the test failed. The first > commit I could find where it failed was b1499f98293f > (Patrice Dumas, 2025-03-09 11:32:48 +0100).
I found the same. > The previous commit (8b7305b506797431, the commit you referred to) passes > the test, after running "make" in the top directory. > > Updating the test results changed "erreur" to "error". This was for > the change that introduced _cache_node_names to bulk convert all the > node names in one go. I assumed this was because the documentlanguage > wasn't set at the time the node names were converted. My guess is that I tested b1499f98293f changes without that commit, my feeling is that there is a change in tests results when there are both 33cbbc0517aa393f780ed6b37effc57d177ee7b0 (Bulk conversion of node names.) and b1499f98293f. I will investigate when I have time. -- Pat
