Hello,
On cygwin, there are warnings for the isalpha and similar functions from
ctype.h, like:
../../info/indices.c: In function 'index_entry_matches':
../../info/indices.c:297:30: warning: array subscript has type 'char'
[-Wchar-subscripts]
297 | else if (!isdigit (*p))
| ^~
../../info/indices.c: In function 'report_index_match':
../../info/indices.c:433:29: warning: array subscript has type 'char'
[-Wchar-subscripts]
433 | upper = isupper (match[start]) ? 1 : 0;
| ~~~~~^~~~~~~
Seems to happen when the implementation of isupper/isalpha... is an
array, and somewhat because is* functions argument is supposed to be
unsigned char. In the glibc manual it is indeed recommended to cast
char to (unsigned char) when calling the functions.
Is it important? Should we cast?
--
Pat
