On Sat, Nov 16, 2024 at 06:54:43PM +0100, Patrice Dumas wrote:
> On Sat, Nov 16, 2024 at 06:47:41PM +0100, Patrice Dumas wrote:
> > On Sat, Nov 16, 2024 at 11:45:11AM -0500, Gavin D. Smith wrote:
> > > branch: master
> > > commit a1e8832ef56932deb90d504d606436934e3540ac
> > > Author: Gavin Smith <gavinsmith0...@gmail.com>
> > > AuthorDate: Sat Nov 16 16:38:16 2024 +0000
> > > 
> > >     Eliminate non-ASCII file names from tarball
> > >     
> > >     * tp/tests/Makefile.am (input/non_ascii.tar): Rule to create
> > >     tar file of all files under input/non_ascii with non-ASCII
> > >     file names.
> > >     
> > 
> > Maybe $(srcdir)/input/non_ascii.tar could depend on $(non_ascii_input)
> > such that the files used in tests are automatically put in the archive
> > and expanded in built_input/non_ascii?  Like
> > 
> > $(srcdir)/input/non_ascii.tar: $(non_ascii_input)
> >     cd $(srcdir)/input && \
> >     tar -c -f non_ascii.tar non_ascii
> 
> Actually, forget that idea, $(non_ascii_input) files are not in the
> tarball...

Yeah, building the tarball works and $(non_ascii_input) aren't added,
but then "make check" fails under tp/tests:

make[2]: *** No rule to make target 'input/non_ascii/osé_utf8.texi', needed by 
'input/non_ascii.tar'. Stop.


> Just need to remember to remove non_ascii.tar when a change is made on
> the files in tests/input/non_ascii/.

Good point.  I can't think of a solution where non_ascii.tar would be
rebuilt automatically.  We could put a note in tp/tests/README.

non_ascii.tar should probably also go in MAINTAINERCLEANFILES.

Reply via email to