On Sat, Oct 26, 2024 at 12:03:19AM +0200, Bruno Haible wrote:
> Would you mind marking them as expected failures?
Why not. I'll let Gavin give his advice too.
> This would have the effect
> that occasional testers like me don't report these failures again, and that
> the CI on mingw does not count them as failures either. It goes like this:
>
> 1) Import the module 'test-xfail' from Gnulib.
>
> 2) Add these lines to tp/tests/Makefile.am or tp/tests/Makefile.onetst:
>
> # Expected test failures.
> XFAIL_TESTS =
> if OS_IS_NATIVE_WINDOWS
This is not correct. Eli reported that his build on pure mingw
succeeded and passed all the tests. The conditional needs to be something else,
maybe something along
AM_CONDITIONAL([OS_IS_NATIVE_WINDOWS_BUILT_ON_CYGWIN],
[case "$host_os" in mingw* | windows*) case "$build_os" in cygwin*) true ;;
*) false ;;
esac
;;
*) false ;;
esac])
> XFAIL_TESTS += \
> test_scripts/formatting_split_nocopying_split_dev_null.sh \
> test_scripts/formatting_cpp_lines.sh \
> test_scripts/formatting_js_license_reuse_output_file.sh \
> test_scripts/formatting_reuse_macro_expand_file.sh \
> test_scripts/encoded_verbatiminclude_names_latin1_html_explicit_encoding.sh
> \
>
> test_scripts/encoded_verbatiminclude_names_latin1_explicit_encoding_rawtext.sh
> endif
>
>
> Bruno
>
>
>
