On čtvrtek 27. listopadu 2025 5:52:29, středoevropský standardní čas Paul
Eggert wrote:
> On 2025-11-25 12:23, Pavel Cahyna wrote:
> > This leads to a perhaps surprising change in
> > behavior that if --dereference is used, an archive can cause a change of
> > metadata of any directory on the system, even if -P is not used and one
> > extracts into an empty directory.
>
> Thanks for pointing that out. It's easy to talk me into restoring the
> placeholder code since I contributed it back in 2000. I installed the
> attached patch, which brings back placeholders if you use --dereference
> (or --absolute-names; might as well). Please give it a try.
Thank you both for the work!
Seems like the patch has broken our packaging CI, the build now fails on:
make[2]: Leaving directory
'/builddir/build/BUILD/tar-1.35.90-build/tar-1.35.90/src'
extract.c: In function ‘extract_link’:
extract.c:1564:39: error: implicit declaration of function
‘contains_dot_dot’ [-Wimplicit-function-declaration]
1564 | && ((! absolute_names_option && contains_dot_dot (link_name))
| ^~~~~~~~~~~~~~~~
make[2]: *** [Makefile:2093: extract.o] Error 1
https://download.copr.fedorainfracloud.org/results/praiskup/tar-upstream-head/fedora-41-ppc64le/09841717-tar/builder-live.log.gz
https://download.copr.fedorainfracloud.org/results/praiskup/tar-upstream-head/fedora-rawhide-x86_64/09841717-tar/builder-live.log.gz
Would you mind taking a look at a follow-up patch?
Pavel
