On Friday, November 16, 2018 4:09:12 PM CET Pavel Raiskup wrote: > On Friday, August 3, 2018 12:48:07 PM CET Paul Eggert wrote: > > Sergey Poznyakoff wrote: > > > The ioctl code needs a good rewrite indeed. However, I'm more concerned > > > about that: > > > > > >> /usr/include/bits/socket.h: In function ‘__cmsg_nxthdr’: > > >> /usr/include/bits/socket.h:315:12: error: cast increases required > > >> alignment of target type [-Werror=cast-align] > > >> __cmsg = (struct cmsghdr *) ((unsigned char *) __cmsg > > > The minimal reproducible file is a one-liner: > > > > > > #include <netdb.h> > > > > > > Running > > > > > > gcc-8 -Wsystem-headers -Wcast-align=strict -Werror -O2 -c 1.c > > > > > > produces the error above. > > > > Although that's annoying, it's a false alarm, since the code properly > > aligns the > > pointer before using it by using CMSG_ALIGN. The warning in rtapelib.c, > > though, > > is not so obviously a false alarm. > > Ping on this.
Could we please fix the build? Or perhaps disable the -Werror by default, at least. I guess this is pretty deterrent failure after ./bootstrap && ./configure && make failure. Pavel
