On Tuesday, July 31, 2018 11:23:27 AM CEST Sergey Poznyakoff wrote:
> Hi Pavel,
> 
> > I don't like that idea; IMO GNU tar should rely on /bin/git to interpret
> > gitignore ('git check-ignore').
> 
> Allow me to disagree. Calling external program when building a file list
> does not seem to be the best idea. First, it would considerably slow
> down the process. Secondly, it would entail additional memory overhead
> (for constructing the command line etc.)

We'd have to use optimization (e.g. check-ignore accepts --stdin, and then it
seem to accept line-by-line input).  And yes, ideally there would be a library
wrapping this all around...

I agree that it would cost something, but it should be optimal (it would be hard
to believe that we could implement .gitignore equivalently && more effective).

Pavel




Reply via email to