-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It has been a while again Brian so I thought I'd touch base again and hope to push some patches this week and get on making a release. I agreed your patch was better than #4, fixed #5, agreed to table #7 for now, and made sure #8 does not allow the user to create the errors. I just wanted to make sure that you came around on #6 and #9 before I push them.
On 8/8/2013 8:45 PM, Brian C. Lane wrote: > 1/9 - Ack. 2/9 - Ack. 3/9 - Ack. 0 sized data area just doesn't > make sense anyway. 4/9 - Nak. I have a more general patch for this > -- not everything inserts DMRAID in there. 5/9 - Shouldn't it use > disk->dev->sector_size instead of hard-coded 512/1024? The logic > seems a bit messy, using an if block instead of the == 1 ? 512 : > 1024 may clean it up a little. If it is already set to 512 (or > really ->sector_size) we don't need to walk the other partitions. > One place where a tab snuck in. Looks pretty ok other than that. > 6/9 - Nak. I'm not sure if this is the right way to handle things. > 7/9 - Nak. I really don't like the giant pile of changes for a > problem that is only in the gpt code. 8/9 - Nak. It looks to me > like removing some of these checks is going to allow user (ui or > library) checks that should fail on new data to pass. I'm ok with > letting us run with these errors so we can fix them, but you > shouldn't be able to enter bad numbers after the warnings. 9/9 - > Nak. I need more details here. The reasoning in the original commit > seems sound to me, and I'd be more worried about busy devices than > the filesystem not matching (I'm not sure we should even be in the > fs detection business anymore). > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSgp0SAAoJEJrBOlT6nu75HNUH/jYmQ2kGYxFieCyFx/E2K69O whNsuxt0Zwo8QHllTnWSrZJ6AEUcmXG2NJDmUUHZQ6SsZWxvyGRmkpD+495up148 KQEVBBtvkQg06Ku3+iOeYC8k0eh+mIzy97JghQQeEDPr6WibCxrSKwT9KTE8Sxur UJ8gJkL/qsJW5hLW4J3B4G/zFHsDNyDbP0kDNaZQI6eRyHSvwh0dczZuRuTC4B5A ahcdFaSpZCy1cx7BLQCHlH2h7wF4+GMa1mtSqVchpAk3WMzF5mYhSWJk0+e0udJg vf0HbnGkCITE5wPnEjs4LgjTErk8BxveMG6maH+dIPfqFjlU+pygIboq2S6zFZI= =EJhI -----END PGP SIGNATURE-----
