Follow-up Comment #5, bug #65537 (group make): [comment #0 original submission:]
> I don't understand the macro guard there. Why would Paul Eggert want to avoid using the pragma in the half-open region between gcc 4.4 and gcc 5, while using it for the half-open region from gcc 4.0 to gcc 4.4? If you're talking about this code: /* Pacify GCC 13.2 in some calls to _GL_EXPR_SIGNED. */ #if defined __GNUC__ && 4 < __GNUC__ + (3 <= __GNUC_MINOR__) # pragma GCC diagnostic ignored "-Wtype-limits" #endif This uses the pragma in GCC 4.3 and later because GCC 4.2 and earlier doesn't support "#pragma GCC diagnostic ignored" and issues a diagnostic about it. With the above code in place, you shouldn't need to put -Wno-error=type-limits into MAKE_CFLAGS. If you're still getting a diagnostic with the above code in place and with MAKE_CFLAGS unchanged from Git, please investigate why the above code doesn't suppress -Wtype-limits. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?65537> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/