On Tue, 2022-10-25 at 08:42 +0200, Martin Reinders wrote: > but from what Paul said in https://lists.gnu.org/archive/html/bug- > make/2019-05/msg00017.html > > > Argh, another glob.c issue. I really need to figure out how to > > update to a newer version, preferably without breaking Windows AND > > pulling in 75% of gnulib stuff in the process. > > I assume we still have to live with these warnings?
Yes, I have no plans to try to resolve this before 4.4. I've been noodling it over in the back of my brain but so far no epiphanies. > Apart from that, there is only one compiler warning: > > src/getopt.c:685:6: warning: add explicit braces to avoid dangling > else [-Wdangling-else] > else > ^ > > A fix had been posted in > https://savannah.gnu.org/bugs/?func=detailitem&item_id=58075. That > looks like a "small effort" change to me, perhaps it can be > incorporated into GNU Make 4.4? The thing is that getopt.c is also an external file, like glob.c. It's not developed by GNU make, it was pulled in from an external toolset (like gnulib--but a long time ago so it's not receiving updates). I prefer to not make changes to these types of files locally but instead find a way to import newer versions. In any event, the C code here is correct, regardless of the warning. Cheers!
