> Date: Fri, 7 Oct 2022 21:37:24 -0700 > Cc: bug-make@gnu.org > From: Paul Eggert <egg...@cs.ucla.edu> > > > I'd appreciate a more high-level description of the idea of the > > change, in addition to the gory details. > > I gave it a shot in the attached patch, which is an improved version of > the previous patch.
Thanks, it's more clear now. > > This opens the file in binary mode where previously it wasn't; what is > > the rationale for the change? And why the "+" part? > > tmpfile uses "wb+" (POSIX requires this) and we should be consistent in > all the paths that create temporary FILE *. The attached patch adds a > comment about this. I don't remember: where is this temporary file read? Because that place where the file is read will most probably need to open the file in binary mode and/or deal with that when it reads the file.
